Add orchard::bundle::BatchValidator
#338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 89.72% 88.99% -0.73%
==========================================
Files 36 37 +1
Lines 3823 3854 +31
==========================================
Hits 3430 3430
- Misses 393 424 +31
Continue to review full report at Codecov.
|
str4d
force-pushed
the
halo2_proofs-0.2.0
branch
2 times, most recently
from
619e1f3 to
be69324
Compare
Adapted from the `BatchValidator` in `zcashd`, that only handles RedPallas signatures.
daira
reviewed
Jun 23, 2022
daira
approved these changes
Jun 23, 2022
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
ebfull
approved these changes
Jun 23, 2022
daira
reviewed
Jun 24, 2022
| @@ -69,6 +69,8 @@ impl BatchValidator { | |||
| pub fn validate<R: RngCore + CryptoRng>(self, vk: &VerifyingKey, rng: R) -> bool { | |||
| if self.signatures.is_empty() { | |||
| // An empty batch is always valid, but is not free to run; skip it. | |||
| // Note that a transaction has at least a binding signature, so if | |||
| // there are no signatures, there are also no proofs. | |||
There was a problem hiding this comment.
I guess this should have more precisely said "A transaction has at least an Orchard binding signature if it has any Orchard components, so if there are no Orchard signatures, there are also no Orchard proofs."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.